New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node:http) always set headersSent to true after end #13794

Merged

Jarred-Sumner merged 2 commits into main from ciro/fix-headersSent

Sep 10, 2024

Member

cirospaciari commented Sep 7, 2024 •

edited

Loading

What does this PR do?

Split from: #13778

Fix: #3458

Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes

How did you verify your code works?

Test

robobun commented Sep 7, 2024 •

edited

Loading

❌ @cirospaciari, your commit a6466cf has 10 failures in #3142:

test/integration/expo-app/expo.test.ts - 1 failing on 🪟 x64-baseline

test/integration/expo-app/expo.test.ts - 1 failing on 🪟 x64

test/cli/watch/watch.test.ts - timeout on 🪟 x64-baseline

test/cli/watch/watch.test.ts - timeout on 🪟 x64

test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64-baseline

test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64

test/napi/napi.test.ts - 16 failing on 🪟 x64-baseline

test/napi/napi.test.ts - 16 failing on 🪟 x64

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/hot.test.ts - 2 failing on 🪟 x64

test/cli/hot/hot.test.ts - 2 failing on 🪟 x64-baseline

test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64

test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64-baseline

test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64

test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64-baseline

test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64

test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64

test/js/bun/http/bun-serve-static.test.ts - 1 failing on 🍎 13 aarch64


          fix headersSent

e9ac924

cirospaciari force-pushed the ciro/fix-headersSent branch from 24c1a03 to e9ac924 Compare

September 9, 2024 18:25


          Apply formatting changes

a6466cf

Jarred-Sumner merged commit 2b50554 into main

45 checks passed

Jarred-Sumner deleted the ciro/fix-headersSent branch

September 10, 2024 00:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet