-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundler): inlining/dead-code-elimination for import.meta.main
(and --compile)
#12867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dylan-conway <[email protected]>
Co-authored-by: Jarred Sumner <[email protected]>
Co-authored-by: dylan-conway <[email protected]>
Co-authored-by: paperdave <[email protected]> Co-authored-by: Jarred Sumner <[email protected]>
Co-authored-by: paperdave <[email protected]>
Co-authored-by: Jarred-Sumner <[email protected]>
❌ @paperdave, your commit 822428e has 20 failures in |
…n into dave/compile-import-meta-main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6009
Fixes #9366
import.meta.main
is inlined to betrue
for bundler entry-points.require.main == module
is now special cased to not not mark a module as CommonJS. This allows it to participate in the inlining.Both of the above also support future --format=cjs (needed for js runtime that uses real commonjs modules) where
import.meta.main
when not known at bundle-time will emitrequire.main == module
(one equal because it is shorter). Inverting this condition will correctly printrequire.main != module
import.meta.main
in--target=node
Node.js does not support
import.meta.main
, so this rewrites both forms into something that will actually work at runtime, as previously neither would.Will bundle to
TODO: This needs a two at-runtime tests, one for commonjs, one for esm. then one file for for true and false