-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard tree search enhancement and tests #4781
Open
ramon-bernardo
wants to merge
24
commits into
otland:master
Choose a base branch
from
ramon-bernardo:wildcard-tree-tests-and-code-quality
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wildcard tree search enhancement and tests #4781
ramon-bernardo
wants to merge
24
commits into
otland:master
from
ramon-bernardo:wildcard-tree-tests-and-code-quality
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPuncker
requested review from
ranisalt,
DSpeichert,
EvilHero90,
nekiro and
MillhioreBT
September 6, 2024 01:39
ranisalt
reviewed
Sep 6, 2024
Ready for review and merge! @ranisalt ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed:
Tests: Added comprehensive unit tests to verify the functionality of the
WildcardTree
.Code modernization: Utilized
auto
in appropriate places to enhance code readability and maintainability. For further insights, please refer to Herb Sutter's explanation.Function renaming: Updated function names to follow snake_case for consistency with modern C++.
Search behavior refinement: Modified the
search
function to return a more descriptive result using a pair consisting of a customSearchResult
enum and the matched string. This change eliminates the need for the previousReturnValue
.Namespace: Removed the instantiation of a root, updating all usages to directly utilize the
tfs::game::wildcardtree
namespace, which enhances clarity and reduces potential errors.Memory management improvements
std::shared_ptr
for improved memory safety, significantly reducing the risk of memory leaks and ensuring proper resource management throughout theWildcardTree
implementation.Usage