Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Issue #240 updating the counter initial value from 0 to 1 #264

Conversation

FanJups
Copy link
Member

@FanJups FanJups commented Mar 3, 2024

close #240

@FanJups FanJups marked this pull request as ready for review March 3, 2024 20:13
@FanJups FanJups force-pushed the 240-should-start-to-count-at-001-instead-of-000 branch from 8b794a2 to b748522 Compare March 3, 2024 21:59
@FanJups
Copy link
Member Author

FanJups commented Mar 5, 2024

Why these tests are not failing ?

@FanJups
Copy link
Member Author

FanJups commented Mar 5, 2024

actions/checkout#881

FanJups added a commit to FanJups/js-generator that referenced this pull request Mar 5, 2024
FanJups added a commit to FanJups/js-generator that referenced this pull request Mar 5, 2024
FanJups added a commit that referenced this pull request Mar 5, 2024
@FanJups FanJups force-pushed the 240-should-start-to-count-at-001-instead-of-000 branch from b748522 to b44d612 Compare March 5, 2024 22:42
@FanJups
Copy link
Member Author

FanJups commented Mar 5, 2024

Now the code of PR branch is used. 💯

FanJups added a commit to FanJups/js-generator that referenced this pull request Mar 5, 2024
@FanJups FanJups closed this Mar 5, 2024
@FanJups FanJups deleted the 240-should-start-to-count-at-001-instead-of-000 branch March 5, 2024 23:01
FanJups added a commit to FanJups/js-generator that referenced this pull request Mar 9, 2024
FanJups added a commit that referenced this pull request Mar 17, 2024
…#264  workflow bug (#266)

* update: Issue #240 updating the counter initial value from 0 to 1 - PR  #264  workflow bug

* trying to make test fail

* Undo "trying to make test fail"

* undo changes

* update:  resolves #267 trigger the Javadoc Workflow only if .github/workflows/javadoc.yml, jsgenerator-core/ or pom.xml has changed

* docs: delete the title's full stop

* update: Issue #240 updating the counter initial value from 0 to 1 - PR  #264  workflow bug

* trying to make test fail

* Undo "trying to make test fail"

* undo changes

* fix: fix tests on jsgenerator-core

* fix: fix tests on jsgenerator-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should start to count at 001 instead of 000
1 participant