Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add javadoc.yml #255 #257

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Add javadoc.yml #255 #257

merged 3 commits into from
Sep 4, 2023

Conversation

shrutikumar15
Copy link
Contributor

@shrutikumar15 shrutikumar15 commented Aug 25, 2023 •
edited by FanJups
Loading

Closes #255

@shrutikumar15 shrutikumar15 changed the title Added javadoc.yml #255 Add javadoc.yml #255 Aug 25, 2023
github-actions[bot]
github-actions bot reviewed Aug 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening your first pull request 😊 ! We really appreciate your work. Happy Coding 🎉🎊 !

@shrutikumar15 shrutikumar15 mentioned this pull request Aug 25, 2023
Closed
@FanJups
Copy link
Member

FanJups commented Aug 27, 2023

@shrutikumar15 , thanks for your commitment. Just some changes to do on javadoc.yml .

@FanJups
Copy link
Member

FanJups commented Aug 27, 2023

@shrutikumar15 , you will notice that I rebased because your branch missed some content from main.

@FanJups
Copy link
Member

FanJups commented Sep 4, 2023

I made some updates, thanks @shrutikumar15 💯 for your time 😊. Now, it is time to............. 🥁🥁🥁🥁🥁.... MERGE !

@FanJups FanJups merged commit 0a62bd0 into osscameroon:main Sep 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@FanJups FanJups FanJups left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run mvn site -B -e -X --projects 'jsgenerator-core' only when the code is merged on main.
2 participants
@shrutikumar15 @FanJups