Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove locks to fix testnet halt #389

Closed
wants to merge 1 commit into from

Conversation

ValarDragon
Copy link
Member

No description provided.

@ValarDragon ValarDragon requested a review from a team November 22, 2022 04:18
@ValarDragon
Copy link
Member Author

See comments from me in prior issues, for why the race conditions are actually the race sensor being broken. Going to sleep now, so can't chase down links, but should be eventually linked to from here: #158

@ValarDragon ValarDragon changed the title Remove locks to fix testnet halt fix: Remove locks to fix testnet halt Nov 22, 2022
@ValarDragon
Copy link
Member Author

Yikes, this fix does not maintain correctness in the generic case. (So would not be ok for the state machine long term, is fine to revive the testnet).

So need to do the deeper cache KV store data store correction

One note: currently we provide no guarantees about iterating during insertion... if you write to a btree (insert/delete), you invalidate all iterators currently iterating on that tree. I don't see that changing any time soon.
(source google/btree#28 (comment))

We deem this sufficient for testnet, so not going to merge this, but will instead make a testnet-only rc, as we make a better cache kv

@czarcas7ic
Copy link
Member

Closing as I believe this is no longer needed

@czarcas7ic czarcas7ic closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants