feat(slo): new way to create/update PrometheusRule #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hy3n4
commented
Nov 3, 2023
Hy3n4
commented
- bump go version to 1.21
- refactored SLO Reconciler
- easier to create an update PrometheusRule when SLO reconcile is triggered (SLO, SLI object changes)
- preparations for using mimirtool package to directly create rules in Mimir
- support for supportive rules - ratio rules created in separate fuctions Signed-off-by: Hy3n4 <[email protected]>
Signed-off-by: Hy3n4 <[email protected]>
- working flow for PrometheusRule update when already exists - prepared for direct write to Mimir using mimirtool package - upgrade go to 1.21 Signed-off-by: Hy3n4 <[email protected]>
Hy3n4
force-pushed
the
prometheus-rule
branch
from
c9f4fb0
to
5814b44
Compare
fourstepper
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.