Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release-drafter gh action #133

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

jmsantorum
Copy link
Contributor

To improve the way releases are done, I want to start with the release content and fill it with the content of the PRs made since the last release.

For that, I'll use https://github.com/marketplace/actions/release-drafter action, and on the next PRs I'll try to fill a CONTRIBUTING.md document and at the same time I'll think about #131 in order to not only fill the release document, but also make a proper release (update project versions, and so on)

Related to #125

.github/release-drafter.yml Outdated Show resolved Hide resolved
.github/release-drafter.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not included it and just keep the simple rules that currently live in the README

https://github.com/oskoperator/osko?tab=readme-ov-file#contributing

@Hy3n4
Copy link
Contributor

Hy3n4 commented Oct 11, 2024

Thank you for the PR! That's awesome. I've included some comments.

@jmsantorum
Copy link
Contributor Author

Thank you for the PR! That's awesome. I've included some comments.

I reviewed it! After simplifying a bit more the config I think now it is ready

@fourstepper
Copy link
Contributor

Thanks! Let's see what it will create in the main branch :D

@fourstepper fourstepper merged commit 83c5b03 into oskoperator:main Oct 14, 2024
1 of 2 checks passed
@fourstepper
Copy link
Contributor

@jmsantorum looks really good the drafter, thanks for the contribution, we appreciate it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants