Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GAP distro tests #1067

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Nov 21, 2024

Resolves #1065.

This is dependent on #1066 and thus includes it.

I've used the ugly hack from oscar-system/GAP_pkg#15 in GAP.Packages.test to avoid GAP packages exiting the process after running their tests. This function could be moved to a package extension on Test once the minimum required julia version is bumped to 1.8.

@lgoettgens lgoettgens force-pushed the lg/CI-distro branch 10 times, most recently from 654d492 to 7088374 Compare November 21, 2024 19:14
name: Test GAP package distro

on:
pull_request:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request:

IMO this shouldn't run on every commit in every PR, as it produces >150 jobs. But I have kept it here for now such that in this PR, we can already see it running.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 72 lines in your changes missing coverage. Please review.

Project coverage is 73.81%. Comparing base (8f4a1a1) to head (c5a9136).

Files with missing lines Patch % Lines
src/packages.jl 0.00% 72 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
- Coverage   74.97%   73.81%   -1.17%     
==========================================
  Files          55       55              
  Lines        4560     4632      +72     
==========================================
  Hits         3419     3419              
- Misses       1141     1213      +72     
Files with missing lines Coverage Δ
src/packages.jl 43.57% <0.00%> (-29.33%) ⬇️
---- 🚨 Try these New Features:

@lgoettgens lgoettgens marked this pull request as ready for review November 21, 2024 19:34
@lgoettgens lgoettgens marked this pull request as draft November 22, 2024 09:14
id: set-matrix
run: julia --project=. -e '
using Artifacts;
output = sprint(print, "gap-packages=", filter(name -> startswith("d", name) || startswith("f", name), readdir(artifact"gap_packages")));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
output = sprint(print, "gap-packages=", filter(name -> startswith("d", name) || startswith("f", name), readdir(artifact"gap_packages")));
output = sprint(print, "gap-packages=", readdir(artifact"gap_packages"));

once we are happy with how this works, we can enable it to test the whole distro and not just ~10 packages

@lgoettgens lgoettgens force-pushed the lg/CI-distro branch 2 times, most recently from e4e994e to 0338bed Compare November 22, 2024 10:29
@lgoettgens lgoettgens force-pushed the lg/CI-distro branch 3 times, most recently from 19c0f2b to c5a9136 Compare November 22, 2024 13:44
@lgoettgens
Copy link
Member Author

The remaining failures (for packages starting with d or f (random two letters)) seem to be more or less genuine:

  • design: its (transitive) dep GRAPE has a build error
  • difsets: its (transitive) dep GRAPE has a build error
  • fining: its (transitive) dep GRAPE has a build error
  • francy: its (transitive) dep zeromqinterface has a build error

So I think that this is ready to review now.

@lgoettgens lgoettgens marked this pull request as ready for review November 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Systematic testing of all packages in the GAP distro
1 participant