-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GAP distro tests #1067
base: master
Are you sure you want to change the base?
Add GAP distro tests #1067
Conversation
654d492
to
7088374
Compare
7088374
to
12ce2c4
Compare
name: Test GAP package distro | ||
|
||
on: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull_request: |
IMO this shouldn't run on every commit in every PR, as it produces >150 jobs. But I have kept it here for now such that in this PR, we can already see it running.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
- Coverage 74.97% 73.81% -1.17%
==========================================
Files 55 55
Lines 4560 4632 +72
==========================================
Hits 3419 3419
- Misses 1141 1213 +72
|
22935a3
to
7846672
Compare
.github/workflows/CI-distro.yml
Outdated
id: set-matrix | ||
run: julia --project=. -e ' | ||
using Artifacts; | ||
output = sprint(print, "gap-packages=", filter(name -> startswith("d", name) || startswith("f", name), readdir(artifact"gap_packages"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
output = sprint(print, "gap-packages=", filter(name -> startswith("d", name) || startswith("f", name), readdir(artifact"gap_packages"))); | |
output = sprint(print, "gap-packages=", readdir(artifact"gap_packages")); |
once we are happy with how this works, we can enable it to test the whole distro and not just ~10 packages
7846672
to
394f42d
Compare
e4e994e
to
0338bed
Compare
aa82d7f
to
96a22f6
Compare
19c0f2b
to
c5a9136
Compare
The remaining failures (for packages starting with
So I think that this is ready to review now. |
Resolves #1065.
This is dependent on #1066 and thus includes it.
I've used the ugly hack from oscar-system/GAP_pkg#15 in
GAP.Packages.test
to avoid GAP packages exiting the process after running their tests. This function could be moved to a package extension onTest
once the minimum required julia version is bumped to 1.8.