Work around nightly breakage by re-allowing Julia.name := val
from GAP
#1006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1004.
This code was last touched in #803, where
Julia.MODULE.name := val
was allowed. In the recent julia nightly change JuliaLang/julia#54678, the implicit creation of global bindings was disabled, one can now only change the value of a global variable but not create a new one.I can think of multiple ways on how to resolve this in GAP.jl:
GAP._setglobal
. This is currently implemented in this PR.Julia.MODULE.name := val
will then run into the new error introduced in Don't let setglobal! implicitly create bindings JuliaLang/julia#54678. One could consider this as a breaking change to GAP.jl, but note that the julia devs didn't consider Don't let setglobal! implicitly create bindings JuliaLang/julia#54678 breaking.Julia.Main
module, and either add our own error or direct to the julia error for all other modules. This was already discussed in AllowJulia.MODULE.x := 1
in GAP code, removeJuliaSetVal
#803 (review).Please let me know what you think about the possible options, and I will be happy to adapt this PR.