Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional function to have special reply when ticket is closing #392

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

JanKraljic
Copy link

It is very nice that reply of email is little different when the ticket is closing.

I have added addition attributes to mail template table and change code little so take other msg template.

Jan Kraljič added 4 commits November 26, 2012 14:37
… is practical when problem is getting worste.
…essage recieved to the ticket.

This is nessary because even if staff already close the ticket, user can still reply that is not solved
@protich
Copy link
Member

protich commented Nov 27, 2012

Thanks for the pull request. Couple of comments....

  1. Not sure I totally buy into separate template in place of the reply template. We've internally discussed possibility of configurable automated followup email - after the ticket is closed. Let's revisit the idea post 1.7 release.
    FYI: Making DB changes also requires upgrade (fast forward) patch - see a closed pull request that involved db changes as a guide.
  2. Make d7655d9 a separate pull request.
  3. 581810d is completely unnecessary - osTicket already does it. See onMessage().

@JanKraljic
Copy link
Author

Mostly i'm preparing customs for our usage. I someone else find it usefull so bi it.

at 1: as you find it is best for your directions

at 2. done

at 3: i'll defenitly check it if it is working as it should and do revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants