Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update persister_oauth2.go to handle special character | coming in t… #3849

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Ajayn84
Copy link

@Ajayn84 Ajayn84 commented Sep 25, 2024

…he scopes as part of consent request

Url encoded and decoded while fetching values from the table, as "|" is a seperator used to store scopes

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

…e scopes as part of consent request

Url encoded and decoded while fetching values from the table,  as "|" is a seperator used to store scopes
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

@Ajayn84 Ajayn84 changed the title Update persister_oauth2.go to handle special character | coming in t… Fix:Update persister_oauth2.go to handle special character | coming in t… Sep 25, 2024
@Ajayn84 Ajayn84 changed the title Fix:Update persister_oauth2.go to handle special character | coming in t… fix:Update persister_oauth2.go to handle special character | coming in t… Sep 25, 2024
@Ajayn84 Ajayn84 changed the title fix:Update persister_oauth2.go to handle special character | coming in t… fix: Update persister_oauth2.go to handle special character | coming in t… Sep 25, 2024
@Ajayn84
Copy link
Author

Ajayn84 commented Dec 2, 2024

@hperl @aeneasr @alnr request your reviews

@Ajayn84 Ajayn84 changed the title fix: Update persister_oauth2.go to handle special character | coming in t… fix: Update persister_oauth2.go to handle special character | coming in t… (https://github.com/ory/hydra/issues/3829) Dec 2, 2024
@Ajayn84 Ajayn84 changed the title fix: Update persister_oauth2.go to handle special character | coming in t… (https://github.com/ory/hydra/issues/3829) fix: Update persister_oauth2.go to handle special character | coming in t… Dec 2, 2024
@Ajayn84
Copy link
Author

Ajayn84 commented Dec 2, 2024

Links to #3829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants