feat: async backchannel logout #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarmam
changed the title
aarmam
force-pushed
the
feature/async-backchannel-logout
branch
from
04545a7
to
88819a7
Compare
aarmam
force-pushed
the
feature/async-backchannel-logout
branch
from
88819a7
to
8f3bd29
Compare
aarmam
force-pushed
the
feature/async-backchannel-logout
branch
from
8f3bd29
to
2db94c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
==========================================
- Coverage 79.64% 79.41% -0.24%
==========================================
Files 112 112
Lines 7955 7885 -70
==========================================
- Hits 6336 6262 -74
- Misses 1217 1222 +5
+ Partials 402 401 -1
Continue to review full report at Codecov.
|
aarmam
force-pushed
the
feature/async-backchannel-logout
branch
2 times, most recently
from
8a65086
to
108a8a2
Compare
aarmam
force-pushed
the
feature/async-backchannel-logout
branch
from
108a8a2
to
c0829aa
Compare
aeneasr
requested changes
Apr 1, 2022
aeneasr
requested changes
Apr 1, 2022
aarmam
force-pushed
the
feature/async-backchannel-logout
branch
from
16fd4a8
to
313cb5f
Compare
aarmam
force-pushed
the
feature/async-backchannel-logout
branch
from
313cb5f
to
53a5a05
Compare
aeneasr
previously approved these changes
Apr 28, 2022
…hannel-logout # Conflicts: # consent/strategy_default.go
aeneasr
approved these changes
Apr 28, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces feature to execute backchannel logout asynchronously.
Use case: User should not have to wait for backchannel requests to finish (4x30sec, with potential connection timeout 1min on each request), when performing logout from all applications using GET /oauth2/sessions/logout or from specific application by using DELETE /oauth2/auth/sessions/consent?trigger_backchannel_logout=true (#2844)
Will add configuration option if needed.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
Tests and documentation will be commited after inital acceptance of the proposed feature.