Fetch only the required subtree of the website instead of the whole site #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## flexbooks #102 +/- ##
=============================================
- Coverage 44.55% 43.66% -0.90%
=============================================
Files 18 19 +1
Lines 1102 1136 +34
Branches 154 163 +9
=============================================
+ Hits 491 496 +5
- Misses 599 628 +29
Partials 12 12 ☔ View full report in Codecov by Sentry. |
rgaudin
approved these changes
Nov 28, 2024
| @@ -0,0 +1,4 @@ | |||
| class BadBookPageError(Exception): | |||
There was a problem hiding this comment.
BadBookPage implies that the Book page as an issue. In this case, the problem is more with the request if I understand correctly. If so, *IncorectBookPage` seems more appropriate.
| if raw_tags is None: | ||
| raise MindtouchParsingError(f"No tags property for page {page_id}") | ||
| raw_tag = raw_tags.get("tag", None) | ||
| if raw_tag is None: |
There was a problem hiding this comment.
Cant we combine those two conditions into one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
LibraryPageobjects, but only the page id as a stringNonefor more obvious handling