-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Info_dashboard package #7424
base: master
Are you sure you want to change the base?
Conversation
Have you taken those image assets from a TP-Link firmware? |
yes |
Of course have written permission from them to use them, right? |
No unfortunately, do I need to change them? if so, should I close this pull and make new one pull request? I'm rookie in GitHub. |
First of all, I want to say it's a tremendous work to have a skin written for luci. If/when the IP/copyright issues of the assets and the name in the package title are resolved, I have the following comments on this PR:
|
There's such a thing called copyright, you can't just take assets without permission, including them in LuCI would make the project eventually liable for any legal consequences. You don't need to close the PR to update the assets, just keep pushing to the same Git branch with your updates. |
Thanks for your replies, ill try my best to solve what you have mentioned in your replies. if I couldn't push them in same branch, i'll close and reopen new one :). |
Please don't - figure out how to use git. That's what it's designed for. |
Okay thanks |
Go grab some royalty-free vector graphics to replace the assets here. And credit/attribute any author involved. |
It's worth checking if TP-Link may have published those assets with the GPL code. Including their brand name in the name of the package might infringe on their copyright tho. |
Is this related to #4185 ? |
No |
Looks considerably better.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be renamed to match luci-mod-info_dashboard
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be renamed to match luci-mod-info_dashboard
.
This package (
luci-app-tplink_dashboard
) introduces a dashboard interface for OpenWrt, inspired by the user interface of TP-Link firmware. The primary goal is to simulate the visual and functional aspects of TP-Link dashboards within the OpenWrt ecosystem.Features
Internet Status: Displays the current connection status dynamically.
Device Detail: Displays information about the router.
DHCP Monitoring: Displays the number of active DHCP clients in real time.
Testing
The package was tested under the following conditions:
Screenshots