Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-openvpn: Handle missing openvpn config file. #7405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morse-miladmohtashamirad
Copy link

@morse-miladmohtashamirad morse-miladmohtashamirad commented Nov 18, 2024

With this change if the specified config file (from UCI) doesn't exist,
it won't error out. instead it treats it as an empty file.
Previously, when clicking edit on the custom_config option in the UI, it
will show an error because the file doesn't exist there by default. As a
result, a user can't easily add (paste) a config file content.

Signed-off-by: Milad Mohtashamirad [email protected]

@jow-

when clicking on this button:
image
It used to show this (if the specified file didn't exist):
image
But now it considers it as an empty file and allows editing (or pasting a content):
image

@systemcrash
Copy link
Contributor

Can you ensure your author and committer tags agree? Also wrap the commit message at 80 chars or so. e.g.

luci-app-openvpn: Handle missing openvpn config file.

With this change if the specified config file (from UCI) doesn't exist,
it won't error out. instead it treats it as an empty file.
Previously, when clicking edit on the custom_config option in the UI, it
will show an error because the file doesn't exist there by default. As a
result, a user can't easily add (paste) a config file content.

Signed-off-by: Milad Mohtashamirad <[email protected]>

With this change if the specified config file (from UCI) doesn't exist,
it won't error out. instead it treats it as an empty file.
Previously, when clicking edit on the custom_config option in the UI, it
will show an error because the file doesn't exist there by default. As a
result, a user can't easily add (paste) a config file content.

Signed-off-by: morse-miladmohtashamirad <[email protected]>
@systemcrash
Copy link
Contributor

Can you fix the SOB line please?

@morse-miladmohtashamirad
Copy link
Author

@systemcrash ,
Sorry, I don't understand how I should fix it.
when I do git commit --amend --signoff it adds Signed-off-by: Milad Mohtashamirad [email protected] to the end of the commit message.
I don't know how I can do it to ensure my author and committer tags agree.

@systemcrash
Copy link
Contributor

Read the test formalities details.

@systemcrash
Copy link
Contributor

when I do git commit --amend --signoff it adds Signed-off-by: Milad Mohtashamirad [email protected] to the end of the commit message.

No - it didn't. Look closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants