luci-base: add PKG_LICENSE_FILES references to this packages #7115
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, packages that do not have the source files in the generic location (luasrc,ucode,htdocs,root,src) can still copy there build files into the build directory if they add the following make target 'Build/Prepare/<luci-packages-name>' to the Makefile. Signed-off-by: Florian Eckert <[email protected]>
Copy the licenses file for luci into the build tree for further processing. This is achieved by the new additional prepare handling, that was added with commit '3b135c381cd5e5efd10353b76344e33e5230c870'. Signed-off-by: Florian Eckert <[email protected]>
The 'luci-base' package is the base package that must always be installed when the LuCI is used. Therefore, according to the license, the license files used by the LuCI must be referenced there. Signed-off-by: Florian Eckert <[email protected]>
|
ping @feckert would you like to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
@jow-
According to the Apache-2.0 license, the information saved in the NOTICE files must be mentioned.
Since the LICENSE and NOTICE files are in the top-level directory of the repository, they do not belong to a specific package and are not therefor referenced.
This pullrequest changes this so that the LICENSE and NOTICE files belong to the luci-base and are therefore referenced as requested.
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packages