Challenge descriptions

Fixes #55

Signed-off-by: Mirko Mollik <[email protected]>

viewer/src/schemas/Credential-Format.json

@@ -1,12 +1,11 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
-  "$id": "https://github.com/openwallet-foundation/credential-format-comparison-sig/tree/main/viewer/viewer/src/schemas/Credential-Format.json",
+  "$id": "https://raw.githubusercontent.com/openwallet-foundation/credential-format-comparison-sig/main/viewer/src/schemas/Credential-Format.json",
   "type": "object",
   "additionalProperties": false,
   "properties": {
     "$schema": {
-      "type": "string",
-      "description": "JSON Schema URI"
+      "$ref": "defs.json#/definitions/Schema"
     },
     "Credential Format": {
       "type": "string",

viewer/src/schemas/Credential-Profile.json

@@ -1,12 +1,11 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
-  "$id": "https://github.com/openwallet-foundation/credential-format-comparison-sig/tree/main/viewer/viewer/src/schemas/Credential-Profile.json",
+  "$id": "https://raw.githubusercontent.com/openwallet-foundation/credential-format-comparison-sig/main/viewer/src/schemas/Credential-Profile.json",
   "type": "object",
   "additionalProperties": false,
   "properties": {
     "$schema": {
-      "type": "string",
-      "description": "JSON Schema URI"
+      "$ref": "defs.json#/definitions/Schema"
     },
     "Credential Profile is commonly called": {
       "type": "string",

viewer/src/schemas/Key-Management.json

@@ -1,12 +1,11 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
-  "$id": "https://github.com/openwallet-foundation/credential-format-comparison-sig/tree/main/viewer/viewer/src/schemas/Key-Management.json",
+  "$id": "https://raw.githubusercontent.com/openwallet-foundation/credential-format-comparison-sig/main/viewer/src/schemas/Key-Management.json",
   "type": "object",
   "additionalProperties": false,
   "properties": {
     "$schema": {
-      "type": "string",
-      "description": "JSON Schema URI"
+      "$ref": "defs.json#/definitions/Schema"
     },
     "Key Management": {
       "type": "string",

viewer/src/schemas/Revocation-Algorithm.json

@@ -1,16 +1,15 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
-  "$id": "https://github.com/openwallet-foundation/credential-format-comparison-sig/tree/main/viewer/viewer/src/schemas/Revocation-Algorithm.json",
+  "$id": "https://raw.githubusercontent.com/openwallet-foundation/credential-format-comparison-sig/main/viewer/src/schemas/Revocation-Algorithm.json",
   "type": "object",
   "additionalProperties": false,
   "properties": {
     "$schema": {
-      "type": "string",
-      "description": "JSON Schema URI"
+      "$ref": "defs.json#/definitions/Schema"
     },
     "Revocation Algorithm": {
       "type": "string",
-      "description": "Glossary"
+      "description": "Unique identifier of the algorithm"
     },
     "Implementation Support (e.g. Libraries) / Active Community": {
       "$ref": "defs.json#/definitions/Implementation-Support"
@@ -43,7 +42,8 @@
     },
     "Performance": {
       "type": "string",
-      "description": "How performant is the revocation mechanism (for issuer, holder and verifier)?"
+      "description": "How performant is the revocation mechanism (for issuer, holder and verifier)?",
+      "$comment": "For this case there could be some king of test framework"
     },
     "Observability": {
       "allOf": [

viewer/src/schemas/Signing-Algorithm.json

@@ -1,16 +1,15 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
-  "$id": "https://github.com/openwallet-foundation/credential-format-comparison-sig/tree/main/viewer/viewer/src/schemas/Signing-Algorithm.json",
+  "$id": "https://raw.githubusercontent.com/openwallet-foundation/credential-format-comparison-sig/main/viewer/src/schemas/Signing-Algorithm.json",
   "type": "object",
   "additionalProperties": false,
   "properties": {
     "$schema": {
-      "type": "string",
-      "description": "JSON Schema URI"
+      "$ref": "defs.json#/definitions/Schema"
     },
     "Signing Algorithm": {
       "type": "string",
-      "description": "Glossary"
+      "description": "A unique identifier for the signing algorithm."
     },
     "Implementation Support (e.g. Libraries) / Active Community": {
       "$ref": "defs.json#/definitions/Implementation-Support"
@@ -39,15 +38,17 @@
     },
     "Performance": {
       "type": "string",
-      "description": "How performant is the signing algorithm?"
+      "description": "How performant is the signing algorithm?",
+      "$comment": "difficult to answer, since there is no performance framework to measure against"
     },
     "Hardware support": {
       "allOf": [
         {
           "$ref": "defs.json#/definitions/Filter"
         },
         {
-          "description": "Is the Signing Algorithm supported by common hardware-backed cryptographic implementations, such as Secure Elements, SecureEnclave, HSM, Strongbox, TEE, TPM"
+          "description": "Is the Signing Algorithm supported by common hardware-backed cryptographic implementations, such as Secure Elements, SecureEnclave, HSM, Strongbox, TEE, TPM",
+          "$comment": "Using different approaches can lead to different results when choosing key lengths or performance measurements"
         }
       ]
     },
@@ -57,7 +58,7 @@
           "$ref": "defs.json#/definitions/Filter"
         },
         {
-          "description": "Is the Signing Algorithm capable of creating a credential scheme, such that two verification processes can not be linked/correlated by colluding Verifiers/Relying Parties"
+          "description": "Is the Signing Algorithm capable of creating a credential scheme, such that two verification processes can not be linked/correlated by colluding Verifiers/Relying Parties?"
         }
       ]
     },

viewer/src/schemas/Trust-Management.json

@@ -1,16 +1,15 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
-  "$id": "https://github.com/openwallet-foundation/credential-format-comparison-sig/tree/main/viewer/viewer/src/schemas/Trust-Management.json",
+  "$id": "https://raw.githubusercontent.com/openwallet-foundation/credential-format-comparison-sig/main/viewer/src/schemas/Trust-Management.json",
   "type": "object",
   "additionalProperties": false,
   "properties": {
     "$schema": {
-      "type": "string",
-      "description": "JSON Schema URI"
+      "$ref": "defs.json#/definitions/Schema"
     },
     "Trust Management": {
       "type": "string",
-      "description": "Glossary"
+      "description": "A unique identifier for the trust management approach."
     },
     "Implementation Support (e.g. Libraries) / Active Community": {
       "$ref": "defs.json#/definitions/Implementation-Support"
@@ -26,7 +25,7 @@
     },
     "Description": {
       "type": "string",
-      "description": "Explanation how this trust management approach works"
+      "description": "Explanation or link to a source how this trust management approach works"
     }
   },
   "required": ["$schema", "Trust Management"],

viewer/src/schemas/defs.json

@@ -1,8 +1,12 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema",
-  "$id": "https://github.com/openwallet-foundation/credential-format-comparison-sig/tree/main/viewer/viewer/src/schemas/defs.json",
+  "$id": "https://raw.githubusercontent.com/openwallet-foundation/credential-format-comparison-sig/main/viewer/src/schemas/defs.json",
   "type": ["object"],
   "definitions": {
+    "Schema": {
+      "type": "string",
+      "description": "JSON Schema URI"
+    },
     "Filter": {
       "type": ["object", "boolean"],
       "properties": {