Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monaco editor cursor mismatch caused css font-size #905

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

chilingling
Copy link
Member

@chilingling chilingling commented Nov 16, 2024

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

What is the current behavior?

【问题描述】
在 CSS 中使用 view-line 覆盖 monaco 编辑器的字体大小,编辑的时候,引起了光标的错乱。
录屏复现:(注意光标位置的变化,一开始是准确的,删除到后面光标并不在对应字母的后面,而是有了 几 px 的距离)

monaco.bug.mp4

Issue Number: N/A

What is the new behavior?

【解决方案】
删除改行覆盖的样式。(后续如果需要修改字体大小,建议通过配置进行修改)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Introduced a button with customizable content in the Meta Code Editor.
    • Enhanced visibility management for the dialog box with a footer for formatting, canceling, and saving.
  • Improvements

    • Improved error handling for JSON parsing and formatting within the editor.
    • Updated props for better customization of button text, title, and other features.
  • Bug Fixes

    • Fixed issues related to setting values based on model types.

Copy link
Contributor

coderabbitai bot commented Nov 16, 2024

Walkthrough

The changes in MetaCodeEditor.vue involve significant updates to the template and logic of the Vue component. Key modifications include the conditional rendering of buttons and slots based on the buttonShowContent prop, enhancements to the tiny-dialog-box component for visibility management, and the introduction of new computed properties. Additionally, error handling has been improved in the formatCode and save methods, and several props have had their default values changed to better reflect their intended use.

Changes

File Change Summary
packages/common/component/MetaCodeEditor.vue - Updated template structure for conditional rendering of buttons and slots.
- Modified tiny-dialog-box for visibility management and added footer template.
- Added new prop: dataType.
- Updated default values for props: buttonText, title, single, showFormatBtn, showErrorMsg, tips.
- Enhanced save method for emitting modelValue.
- Improved error handling in formatCode.

Possibly related PRs

  • fix:adjust editor style #901: The changes in VueMonaco.vue involve adjustments to the Monaco editor component, which is relevant to the updates made in MetaCodeEditor.vue regarding editor functionalities and styles.

Suggested labels

ready_for_review

Suggested reviewers

  • hexqi

Poem

🐇 In the meadow where code does play,
A button shines bright, guiding the way.
With props all adjusted, the logic refined,
Our editor dances, with features aligned.
Errors now handled, in JSON's embrace,
Let's save our work, with a smile on our face! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ef582f8 and a75c713.

📒 Files selected for processing (1)
  • packages/common/component/MetaCodeEditor.vue (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/common/component/MetaCodeEditor.vue

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added bug Something isn't working refactor-main refactor/develop branch feature labels Nov 16, 2024
@chilingling chilingling marked this pull request as ready for review November 16, 2024 02:37
@hexqi hexqi merged commit bc501cf into opentiny:refactor/develop Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor-main refactor/develop branch feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants