feat(core): add optional name to kas registry CRUD commands #429
Conversation
There was a problem hiding this comment.
@jakedoublev do you mind adding a couple of negative tests in addition to the positive tests?
Perhaps a few tests that:
- an invalid name? Do we allow non-ascii characters for example?
- a name that is too long? (is there a limit)
@damorris25 Sure thing. The negative paths around name validity are enforced by protos and unit tested but I don't mind if we end to end test them as well with this CLI as the primary client engaging the APIs. There's also a separate PR in flight to provide more helpful/clear validation to the key itself: #428 |
@ryanulit That's exactly right. If we don't marshal the key to JSON first and convert the proto type to a string instead, we get the key type in the table output, so we can remove the extra detection/variable. We were also inconsistent between CRUD commands before and are now consistent. |
🤖 I have created a release *beep* *boop* --- ## [0.16.0](v0.15.0...v0.16.0) (2024-11-20) ### Features * assertion verification disable ([#419](#419)) ([acf5702](acf5702)) * **core:** add `subject-mappings match` to CLI ([#413](#413)) ([bc56c19](bc56c19)) * **core:** add optional name to kas registry CRUD commands ([#429](#429)) ([f675d86](f675d86)) * **core:** adds assertions to encrypt subcommand ([#408](#408)) ([8f0e906](8f0e906)) * **core:** adds storeFile to save encrypted profiles to disk and updates auth to propagate tlsNoVerify ([#420](#420)) ([f709e01](f709e01)) * refactor encrypt and decrypt + CLI examples ([#418](#418)) ([e681823](e681823)) * support --with-access-token for auth ([#409](#409)) ([856efa4](856efa4)) ### Bug Fixes * **core:** dev selectors employ flattening from platform instead of jq ([#411](#411)) ([57966ff](57966ff)) * **core:** improve readability of TDF methods ([#424](#424)) ([a88d386](a88d386)) * **core:** remove trailing slashes on host/platformEndpoint ([#415](#415)) ([2ffd3c7](2ffd3c7)), closes [#414](#414) * **core:** revert profiles file system storage last commit ([#427](#427)) ([79f2079](79f2079)) * updates sdk to 0.3.19 with GetTdfType fixes ([#425](#425)) ([0a9adfe](0a9adfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
No description provided.