Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid broken macaroonbakery release #632

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

javacruft
Copy link
Contributor

macaroonbakery 1.3.3 has a broken protobuf dependency, add a requirement to avoid that specific release:
go-macaroon-bakery/py-macaroon-bakery#94

(cherry picked from commit 8be4948)

macaroonbakery 1.3.3 has a broken protobuf dependency, add a requirement
to avoid that specific release:
go-macaroon-bakery/py-macaroon-bakery#94

(cherry picked from commit 8be4948)
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e3b91b) 89.14% compared to head (12ff9e7) 89.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##           libjuju-3.1     #632   +/-   ##
============================================
  Coverage        89.14%   89.14%           
============================================
  Files               44       44           
  Lines             4689     4689           
============================================
  Hits              4180     4180           
  Misses             509      509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajkavanagh
Copy link
Collaborator

This looks like it broke due to breaking changes between Juju 2.9 -> 3.1:

Model       Cloud/Region         Type  Status     Machines  Units  Access  Last connection
controller  localhost/localhost  lxd   available         1      1  admin   just now
++ juju models --format yaml
++ grep '^- name:.*zaza'
++ cut -f2 -d/
+ model=
+ juju status -m
+ tee logs/juju-status.txt
ERROR option needs an argument: -m
+ juju crashdump -m -o logs/
ERROR juju: "crashdump" is not a juju command. See "juju --help".

Is it important for this branch to fix it, or would you just like it merged for convenience?

@javacruft
Copy link
Contributor Author

@ajkavanagh I really need to unblock our charm testing gate - I'm running this cherry-pick through with https://review.opendev.org/c/openstack/sunbeam-charms/+/903563 to check it works OK

@ajkavanagh
Copy link
Collaborator

@ajkavanagh I really need to unblock our charm testing gate - I'm running this cherry-pick through with https://review.opendev.org/c/openstack/sunbeam-charms/+/903563 to check it works OK

Right, that seems reasonable. Once that passes, we can merge.

@javacruft
Copy link
Contributor Author

@ajkavanagh review passed testing 👍

@ajkavanagh
Copy link
Collaborator

@ajkavanagh review passed testing 👍

Oh yes! It all runs upstream; I was mistakenly looking for zOSCI. Merging now.

@ajkavanagh ajkavanagh merged commit 00af63d into openstack-charmers:libjuju-3.1 Dec 13, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants