Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added progress indicator on Insight Screen #3484

Merged
merged 22 commits into from
Nov 22, 2024
Merged

Added progress indicator on Insight Screen #3484

merged 22 commits into from
Nov 22, 2024

Conversation

aurangzaibumer
Copy link
Contributor

@aurangzaibumer aurangzaibumer commented Sep 6, 2024

added progress indicator while quering/fetching the data on insight screen

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3476

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@aurangzaibumer aurangzaibumer self-assigned this Sep 6, 2024
@aurangzaibumer aurangzaibumer changed the title added progress indicator while quering/fetching the data on insight s… Added progress indicator on Insight Screen Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.5%. Comparing base (f6e9faa) to head (0cff704).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3484     +/-   ##
=========================================
+ Coverage     27.3%   27.5%   +0.1%     
  Complexity     787     787             
=========================================
  Files          282     282             
  Lines        14699   14520    -179     
  Branches      2635    2601     -34     
=========================================
- Hits          4023    3996     -27     
+ Misses       10131    9981    -150     
+ Partials       545     543      -2     
Flag Coverage Δ
engine 63.8% <ø> (ø)
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../quest/ui/usersetting/UserInsightScreenFragment.kt 43.4% <ø> (ø)
...e/quest/ui/usersetting/UserSettingInsightScreen.kt 17.6% <ø> (+<0.1%) ⬆️
...fhircore/quest/ui/usersetting/UserSettingScreen.kt 2.2% <ø> (ø)

... and 9 files with indirect coverage changes

---- 🚨 Try these New Features:

@ndegwamartin
Copy link
Contributor

@aurangzaibumer tested the update it still doesn't seem to work, check out the recording below:

Screen_recording_20240919_194616.webm

@aurangzaibumer
Copy link
Contributor Author

3476.mp4

I have created some household members in a family and recorded this.

ndegwamartin
ndegwamartin previously approved these changes Nov 1, 2024
dubdabasoduba
dubdabasoduba previously approved these changes Nov 1, 2024
pld
pld previously approved these changes Nov 15, 2024
@pld pld enabled auto-merge November 15, 2024 06:27
@pld pld assigned ndegwamartin and unassigned aurangzaibumer Nov 15, 2024
@LZRS LZRS dismissed stale reviews from dubdabasoduba, ndegwamartin, and pld via 11b11f3 November 15, 2024 09:15
@LZRS LZRS force-pushed the 3476 branch 2 times, most recently from 005a9d5 to 8aa24d5 Compare November 21, 2024 00:46
@LZRS LZRS disabled auto-merge November 21, 2024 01:41
@LZRS LZRS added the DNM DO NOT MERGE label Nov 21, 2024
@pld pld enabled auto-merge November 21, 2024 19:45
@pld pld added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 8ee171a Nov 22, 2024
5 checks passed
@pld pld deleted the 3476 branch November 22, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insights view not rendering correct unsynced records status on initial load
5 participants