[ZEIR] - Growth Monitoring : Z-Score Computation #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic resource in bundle when CQL is executed for zeir growth monitoring
Codecov Report
@@ Coverage Diff @@
## main #2745 +/- ##
=========================================
+ Coverage 64.5% 65.5% +1.0%
+ Complexity 1075 1051 -24
=========================================
Files 218 220 +2
Lines 9635 9821 +186
Branches 1897 1802 -95
=========================================
+ Hits 6218 6441 +223
- Misses 2234 2276 +42
+ Partials 1183 1104 -79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pld
requested changes
Sep 13, 2023
Comment on lines
577
to
587
| questionnaire.cqfLibraryIds().forEach { libraryId -> | ||
| if ( | ||
| libraryId == "223758" | ||
| ) { // Resource id for Library that calculates Z-score in ZEIR application | ||
| // Adding 4 basic resources which contain the Data needed for Z-score calculation | ||
| val basicResourceIds = listOf("223754", "223755", "223756", "223757") | ||
| basicResourceIds.forEach { resourceId -> | ||
| val basicResource = defaultRepository.loadResource(resourceId) as Basic? | ||
| bundle.addEntry(Bundle.BundleEntryComponent().setResource(basicResource)) | ||
| } | ||
| } |
There was a problem hiding this comment.
can you please create a new issue to make this generic with a proposal on how to do this and add a TODO on line 577 that links to that issue
ellykits
requested changes
Sep 13, 2023
| bundle = newBundle, | ||
| questionnaire = questionnaire, | ||
| ) | ||
| withContext(Dispatchers.IO) { |
There was a problem hiding this comment.
Can you use dispatcherProvider.io() here instead? The provider is already injected as a constructor parameter
…g' into issue-1535-zeir-growth-monitoring
pld
previously approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue: https://github.com/onaio/fhir-resources/issues/1535
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes https://github.com/onaio/fhir-resources/issues/1535
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile