Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save sync timestamp for SyncJobStatuses with timestamp #2731

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Sep 7, 2023

SyncJobStatuses Glitch, Failed and Finished have timestamp. Also trigger refresh of Main activity sidemenu when timestamp is saved.

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/onaio/fhir-resources/issues/2645

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

SyncJobStatuses Glitch, Failed and Finished have timestamp.
Also trigger refresh of Main activity sidemenu when timestamp is saved.

Signed-off-by: Elly Kitoto <[email protected]>
pld
pld previously approved these changes Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2731 (fc2b148) into main (ad3a737) will increase coverage by 2.3%.
Report is 44 commits behind head on main.
The diff coverage is 66.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2731     +/-   ##
=========================================
+ Coverage     64.5%   66.8%   +2.3%     
+ Complexity    1075    1072      -3     
=========================================
  Files          218     220      +2     
  Lines         9635    9798    +163     
  Branches      1897    1801     -96     
=========================================
+ Hits          6218    6553    +335     
+ Misses        2234    2118    -116     
+ Partials      1183    1127     -56     
Flag Coverage Δ
engine 73.4% <72.7%> (+0.7%) ⬆️
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 62.4% <64.7%> (+3.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...hircore/engine/domain/model/FhirResourceConfigs.kt 43.2% <0.0%> (-1.3%) ⬇️
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...ore/engine/util/helper/TransformSupportServices.kt 80.0% <0.0%> (-2.8%) ⬇️
...ster/fhircore/quest/ui/profile/ProfileViewModel.kt 45.7% <0.0%> (-0.3%) ⬇️
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...rt/measure/models/MeasureReportPopulationResult.kt 25.0% <0.0%> (-12.5%) ⬇️
...ort/measure/screens/MeasureReportSubjectsScreen.kt 0.0% <0.0%> (ø)
...er/fhircore/quest/ui/register/RegisterViewModel.kt 68.2% <8.3%> (-3.2%) ⬇️
...fhircore/quest/ui/appsetting/AppSettingActivity.kt 42.8% <14.2%> (-5.6%) ⬇️
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 36.6% <20.0%> (+2.4%) ⬆️
... and 37 more

... and 36 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

Signed-off-by: Elly Kitoto <[email protected]>
@ellykits ellykits merged commit f8758ba into main Sep 8, 2023
6 checks passed
@ellykits ellykits deleted the fix-sync-issue branch September 8, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants