-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to latest FHIR engine SDK #2718
Conversation
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
- Update sync and other code implementations using FhirEngine Search API Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2718 +/- ##
=========================================
+ Coverage 64.5% 65.6% +1.0%
+ Complexity 1075 1050 -25
=========================================
Files 218 220 +2
Lines 9635 9814 +179
Branches 1897 1801 -96
=========================================
+ Hits 6218 6439 +221
- Misses 2234 2272 +38
+ Partials 1183 1103 -80
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
@@ -92,7 +91,7 @@ constructor( | |||
classType: Class<out Resource>, | |||
): List<Resource> { | |||
return withContext(dispatcherProvider.io()) { | |||
val searchQuery = | |||
/* val searchQuery = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove these lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be done in a separate PR #2730
@@ -158,7 +159,7 @@ class BaseP2PTransferDaoTest : RobolectricTest() { | |||
} | |||
val searchQuerySlot = slot<SearchQuery>() | |||
|
|||
coVerify { fhirEngine.search<Patient>(capture(searchQuerySlot)) } | |||
// coVerify { fhirEngine.search<Patient>(capture(searchQuerySlot)) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be addressed via PR #2730
@@ -130,8 +130,6 @@ class QuestionnaireActivity : BaseMultiLanguageActivity() { | |||
} | |||
|
|||
registerFragmentResultListener() | |||
|
|||
viewModel.setProgressState(QuestionnaireProgressState.QuestionnaireLaunch(false)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this no longer necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The progress dialog is dismissed in the finally
section of the try-catch
block.
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
This PR requires re-installation of the app. |
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2563 or Closes #2708
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file