Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Engage Custom PR #2648

Closed
wants to merge 26 commits into from
Closed

New Engage Custom PR #2648

wants to merge 26 commits into from

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@FikriMilano
Copy link
Collaborator Author

Pls not to merge latest from main

@FikriMilano
Copy link
Collaborator Author

This PR won't go to main, just to highlight

@FikriMilano FikriMilano marked this pull request as draft August 7, 2023 13:59
@FikriMilano
Copy link
Collaborator Author

@f-odhiambo kindly try this branch, and if it's good, let's close these 2 similar PRs:
#2647
#2615

@f-odhiambo
Copy link
Contributor

@FikriMilano You can resolve the conflcits

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2648 (e9640d0) into main (ad3a737) will increase coverage by 0.5%.
Report is 43 commits behind head on main.
The diff coverage is 63.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2648     +/-   ##
=========================================
+ Coverage     64.5%   65.1%   +0.5%     
- Complexity    1075    1100     +25     
=========================================
  Files          218     220      +2     
  Lines         9635    9840    +205     
  Branches      1897    1955     +58     
=========================================
+ Hits          6218    6406    +188     
+ Misses        2234    2187     -47     
- Partials      1183    1247     +64     
Flag Coverage Δ
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 59.9% <61.5%> (+0.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...gine/configuration/workflow/ApplicationWorkflow.kt 100.0% <ø> (ø)
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...ore/engine/util/helper/TransformSupportServices.kt 80.0% <0.0%> (-2.8%) ⬇️
...est/data/report/measure/MeasureReportRepository.kt 66.6% <0.0%> (-1.6%) ⬇️
...ster/fhircore/quest/ui/profile/ProfileViewModel.kt 44.1% <0.0%> (-1.8%) ⬇️
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...rt/measure/models/MeasureReportPopulationResult.kt 25.0% <0.0%> (-12.5%) ⬇️
...ter/fhircore/quest/data/QuestXFhirQueryResolver.kt 19.0% <11.1%> (-81.0%) ⬇️
...fhircore/quest/ui/appsetting/AppSettingActivity.kt 42.8% <14.2%> (-5.6%) ⬇️
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 36.6% <20.0%> (+2.4%) ⬆️
... and 21 more

... and 3 files with indirect coverage changes

@f-odhiambo
Copy link
Contributor

@FikriMilano I think we can close this PR if no longer required

@FikriMilano
Copy link
Collaborator Author

Yep, thanks for the reminder!

@FikriMilano FikriMilano deleted the new-engage-custom branch August 11, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Columbia DNM DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants