-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Engage Custom PR #2648
New Engage Custom PR #2648
Conversation
Pls not to merge latest from main |
android/quest/src/main/java/org/smartregister/fhircore/quest/data/QuestXFhirQueryResolver.kt
Show resolved
Hide resolved
This PR won't go to main, just to highlight |
@f-odhiambo kindly try this branch, and if it's good, let's close these 2 similar PRs: |
@FikriMilano You can resolve the conflcits |
…ofile post submit
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Keeping the logs, it's quite useful.
Codecov Report
@@ Coverage Diff @@
## main #2648 +/- ##
=========================================
+ Coverage 64.5% 65.1% +0.5%
- Complexity 1075 1100 +25
=========================================
Files 218 220 +2
Lines 9635 9840 +205
Branches 1897 1955 +58
=========================================
+ Hits 6218 6406 +188
+ Misses 2234 2187 -47
- Partials 1183 1247 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...oid/quest/src/main/java/org/smartregister/fhircore/quest/util/extensions/ConfigExtensions.kt
Outdated
Show resolved
Hide resolved
568c001
to
af45af6
Compare
…new-engage-custom
…and not close given set of tasks
e351c3d
to
e9640d0
Compare
@FikriMilano I think we can close this PR if no longer required |
Yep, thanks for the reminder! |
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file