OCPBUGS-37220: Fix DNS for Gateway API on AWS

[candita]

Before this change, a new Gateway API dnsRecord created on AWS was being deleted right after it was published.

pkg/operator/controller/dns/controller.go - make the general watch for dnsRecords skip Gateway API dnsRecords

pkg/operator/controller/gateway-service-dns/controller.go - add a predicate to ensure only dsnRecords for Gateway API are watched; remove the restriction that watched only Services in openshift-ingress namespace; export the ManagedByIstioLabelKey for use by the general dns controller; add logging to ensureDNSRecordsForGateway and deleteStaleDNSRecordsForGateway

pkg/resources/dnsrecord/dns.go - minor tweak and logging added to EnsureDNSRecord
pkg/dns/aws/dns.go - add logging

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-37220, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before this change, a new Gateway API dnsRecord created on AWS was being deleted right after it was published.

pkg/operator/controller/dns/controller.go - make the general watch for dnsRecords skip Gateway API dnsRecords

pkg/operator/controller/gateway-service-dns/controller.go - add a predicate to ensure only dsnRecords for Gateway API are watched; remove the restriction that watched only Services in openshift-ingress namespace; export the ManagedByIstioLabelKey for use by the general dns controller; add logging to ensureDNSRecordsForGateway and deleteStaleDNSRecordsForGateway

pkg/resources/dnsrecord/dns.go - minor tweak and logging added to EnsureDNSRecord
pkg/dns/aws/dns.go - add logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from candita. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[candita]

/test all

[candita]

/jira refresh

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-37220, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[candita]

/test all

[openshift-ci]

@candita: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	3101dbc	link	false	/test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[candita]

/lifecycle-remove stale