Fix ansible linter (#6)

.ansible-lint

@@ -1,6 +1,16 @@
 mock_roles:
   - rhtelco.automation.hyperv
   - rhtelco.automation.hv_provision
+
 exclude_paths:
   - playbooks/_*.yml
-  # - roles/
+  - roles/storage
+
+skip_list:
+  - skip_this_tag
+
+warn_list:
+  - fqcn[action-core]
+  - galaxy[no-changelog]
+  - var-naming[no-role-prefix]
+  - name[play]

.github/workflows/ansible-lint.yml

@@ -16,4 +16,4 @@ jobs:
           args: "-c .ansible-lint"
           setup_python: "true"
           working_directory: ""
-          requirements_file: ""
+          requirements_file: "ansible-requirements.yaml"

ansible-requirements.yaml

@@ -7,8 +7,3 @@ collections:
     version: 5.0.0
   - name: kubevirt.core # Utilized in deploy_manager_vm role
     version: 2.1.0
-
-roles:
-  - name: storage  # for managing storage on HV
-    src: https://github.com/linux-system-roles/storage
-    version: 1.8.1

galaxy.yml

@@ -9,6 +9,9 @@ license:
 tags:
   - automation
   - telco
+  - infrastructure
+  - linux
+  - tools
 dependencies: {}
 repository: https://github.com/openshift-kni/telco-ci
 documentation: https://github.com/openshift-kni/telco-ci

meta/runtime.yml

@@ -1 +1 @@
-requires_ansible: ">=2.8"
+requires_ansible: ">=2.15.0"

playbooks/performance_profile.yml

@@ -1,5 +1,4 @@
 ---
-##
 # This playbook applies performance profile configmap to
 # hosted cluster nodes.
 # Note: Currently this playbook assumes there is only one
@@ -10,13 +9,13 @@
 # Provide
 # kubeconfig path of the management clusters example: /home/kni/hcp-jobs/sno-cnfqe1/config/kubeconfig
 #
-#ansible-playbook -vv playbooks/performance_profile.yml -e kubeconfig=/home/kni/hcp-jobs/sno-cnfqe1/config/kubeconfig
-##
+# ansible-playbook -vv playbooks/performance_profile.yml -e kubeconfig=/home/kni/hcp-jobs/sno-cnfqe1/config/kubeconfig
 
 - hosts: localhost
   tasks:
-  - name: Apply performance profile
-    vars:
-      pp_kubeconfig: "{{ kubeconfig }}"
-    include_role:
-      name: performance_profile
+
+    - name: Apply performance profile
+      vars:
+        pp_kubeconfig: "{{ kubeconfig }}"
+      include_role:
+        name: performance_profile

roles/performance_profile/tasks/main.yml

@@ -59,7 +59,7 @@
         namespace: "{{ nodepool_namespace }}"
       spec:
         tuningConfig:
-        - name: "{{ performance_configmap_name }}"
+          - name: "{{ performance_configmap_name }}"
 
 - name: Check if Nodepool is updating
   kubernetes.core.k8s_info: