cnf network: fix frrnodestatus test case #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkopels
force-pushed
the
update-frrstatus-test-case
branch
5 times, most recently
from
ce6776c
to
c088d09
Compare
evgenLevin
reviewed
Nov 14, 2024
| @@ -354,7 +354,20 @@ var _ = Describe("FRR", Ordered, Label(tsparams.LabelFRRTestCases), ContinueOnFa | |||
| frrNodeState, err := metallb.ListFrrNodeState(APIClient) | |||
| Expect(err).ToNot(HaveOccurred(), "Failed to verify BGP routes") | |||
|
|
|||
| return frrNodeState[0].Object.Status.RunningConfig | |||
| // Iterate over all the nodes and append worker-0 if present | |||
There was a problem hiding this comment.
Please remove this comment or modify to not mention worker-0
|
|
||
| return frrNodeState[0].Object.Status.RunningConfig | ||
| var frrWorker1Status *metallb.FrrNodeStateBuilder |
There was a problem hiding this comment.
IMO better to create help func to move this logic, something like:
func findNodeByName(frrNodeState []metallb.FrrNodeStateBuilder, nodeName string) *metallb.FrrNodeStateBuilder {
for _, node := range frrNodeState {
if node.Definition.Name == nodeName {
return node
}
}
return nil
}
and then it should be something like:
frrWorker1Status := findNodeByName(frrNodeState, cnfWorkerNodeList[1].Definition.Name)
Expect(frrWorker1Status).ToNot(BeNil(), fmt.Sprintf("Node with name %s not found", cnfWorkerNodeList[1].Definition.Name))
c088d09
to
0dec676
Compare
ajaggapa
reviewed
Nov 15, 2024
| @@ -354,7 +354,11 @@ var _ = Describe("FRR", Ordered, Label(tsparams.LabelFRRTestCases), ContinueOnFa | |||
| frrNodeState, err := metallb.ListFrrNodeState(APIClient) | |||
There was a problem hiding this comment.
metallb.ListFrrNodeState(APIClient, client.ListOptions{
FieldSelector: fields.SelectorFromSet(fields.Set{"metadata.name": "worker-0"})})
We can filter worker-0 here like this
ajaggapa
reviewed
Nov 15, 2024
| @@ -372,10 +376,12 @@ var _ = Describe("FRR", Ordered, Label(tsparams.LabelFRRTestCases), ContinueOnFa | |||
| // Get the routes | |||
| frrNodeState, err := metallb.ListFrrNodeState(APIClient) | |||
There was a problem hiding this comment.
metallb.ListFrrNodeState(APIClient, client.ListOptions{
FieldSelector: fields.SelectorFromSet(fields.Set{"metadata.name": "worker-1"})})
Same like above for worker-1
ajaggapa
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #266