fix(parser): reset stream position for direct string input, close #35 #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
The root cause of #35 is as follows
https://github.com/openqasm/qe-qasm/blob/main/lib/Parser/QasmParser.y#L338-L342
Here
IIS
andISS
points to the same buffer, asstd::getline
moves the pointer to the next line, we got the wrong line number when directly parsing string.Thus we just need to reset the position of
IIS
to makeQASM::QasmPreprocessor::Instance().Preprocess(IIS)
work as expectedI did not find any test codes in this repo to directly test
QasmParser.y
. I'm willing to add some tests and wish to know the proper way to do so.Thanks,
Yilun