-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECDSA With SHA1 & SHA256 Support #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xVikasRushi
changed the title
ECDSA With SHA1 Support
ECDSA With SHA1 & SHA256 Support
Jul 30, 2024
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECDSA With SHA1 & SHA256 Support
This pr implements passport verification using P256 ECDSA.
Changes
1. P256 ECDSA Imports
2. Input Processing and Leaf Calculation (
getLeaf
function)3. Verifier Circuit
passport_verifier_ecdsaWithSHA1Encryption.circom
passport_verifier_ecdsaWithSHA256Encryption.circom
dsc_modules[2][k]
structure where k is the number of bits.signature_r
andsignature_s
components.4. Register Circuit
register_ecdsaWithSHA1Encryption.circom
register_ecdsaWithSHA256Encryption.circom