Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8345249: Apply some conservative cleanups in FileURLConnection #22459

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

8345249: Apply some conservative cleanups in FileURLConnection #22459

wants to merge 12 commits into from
+26 −37

Commits on Nov 29, 2024

  1. Replace filename field with file.getPath()

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    46ed3d1 View commit details
    Browse the repository at this point in the history

  2. Make file field final

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    280e82d View commit details
    Browse the repository at this point in the history

  3. Rename files field to directoryListing

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    b19b893 View commit details
    Browse the repository at this point in the history

  4. Remove contentType field

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    6d9cf02 View commit details
    Browse the repository at this point in the history

  5. Remove unneccessary catch/rethrow of IOException

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    2e29cc0 View commit details
    Browse the repository at this point in the history

  6. Reorder instance fields

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    95ce976 View commit details
    Browse the repository at this point in the history

  7. Make instance fields private

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    633b18b View commit details
    Browse the repository at this point in the history

  8. Remove unused local variables in getInputStream

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    eccf281 View commit details
    Browse the repository at this point in the history

  9. Update copyright year

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d990e83 View commit details
    Browse the repository at this point in the history

  10. Avoid explicit type parameter when calling Arrays::asList

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    06b2a23 View commit details
    Browse the repository at this point in the history

  11. Use enhanced for loop when constructing directory list

    @eirbjo
    eirbjo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    f9efa3b View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2024

  1. Replace String::valueOf with Long::toString

    @eirbjo
    eirbjo committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    16ee08c View commit details
    Browse the repository at this point in the history