-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8336759: C2: int counted loop with long limit not recognized as counted loop #22449
Draft
tabjy
wants to merge
17
commits into
openjdk:master
Choose a base branch
from
tabjy:8336759-int-loop-long-limit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tier-1 passing
👋 Welcome back kxu! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
tabjy
changed the title
8336759: int counted loop with long limit not recognized as counted loop
8336759: C2: int counted loop with long limit not recognized as counted loop
Nov 29, 2024
/reviewers 2 reviewer C2 changes |
merykitty
reviewed
Nov 29, 2024
rwestrel
reviewed
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements JDK-8336759 that recognizes int counted loops with long limits.
Currently, patterns like
for ( int i =...; i < long_limit; ...)
where inti
is implicitly promoted to long (i.e.,(long) i < long_limit
) is not recognized as (int) counted loop. This patch speculatively and optimistically converts long limits to ints and deoptimize if the limit is outside int range, allowing more optimization opportunities.In other words, it transforms
to
This could benefit calls to APIs like
long MemorySegment#byteSize()
when iterating over a long limit.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22449/head:pull/22449
$ git checkout pull/22449
Update a local copy of the PR:
$ git checkout pull/22449
$ git pull https://git.openjdk.org/jdk.git pull/22449/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22449
View PR using the GUI difftool:
$ git pr show -t 22449
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22449.diff