csr_regfile: Fix S-mode traps when H extension is enabled #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Hypervisor extension is enabled, the logic required to properly trap to S mode is currently excluded. Fix this by adjusting the if block. Signed-off-by: Nils Wistoff <[email protected]>
|
❌ failed run, report available here. |
|
|
|
❌ failed run, report available here. |
Signed-off-by: Nils Wistoff <[email protected]>
|
❌ failed run, report available here. |
|
@JeanRochCoulon I have worked around the lint warning. Gate-level simulation still fails, but I can't see the reason for this |
|
HEllo @niwis The gate simulation is failed, but it is a false fail. Do not worry about it. I will merge ! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2587. If Hypervisor extension is enabled, the logic required to properly trap to S mode is currently excluded (Since #2346, the
elseblock below the diff is no longer taken ifCVA6Cfg.RVH && !trap_to_v). This means that supervisor traps are currently broken in the presence of H extension. Fix this by adjusting theifcondition.