Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump core/cache_subsystem/hpdcache from b4519e7 to edd501c #2578

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps core/cache_subsystem/hpdcache from b4519e7 to edd501c.

Commits
  • edd501c fix linewidth
  • 1b14a1d Fix data width warnings
  • 59e290e Fix cast int' into unsigned' when required
  • aa4a938 mem_req_write_arb: remove dependency between req_ready and req_data_valid
  • 9df7e23 ci: parallelize run jobs
  • a287173 fix: handling of errors for write miss requests
  • 04b8984 Add nonregression validation on push and pull-requests in the CI
  • 7aa4c82 tb: add support for SC versions greater than 3.0.0
  • ab4b7ea fix: prefetch requests should update PLRU on cache hit
  • 4c2a59e tb: add dependencies URL links in the README
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [core/cache_subsystem/hpdcache](https://github.com/openhwgroup/cv-hpdcache) from `b4519e7` to `edd501c`.
- [Release notes](https://github.com/openhwgroup/cv-hpdcache/releases)
- [Commits](openhwgroup/cv-hpdcache@b4519e7...edd501c)

---
updated-dependencies:
- dependency-name: core/cache_subsystem/hpdcache
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Contributor

github-actions bot commented Nov 4, 2024

❌ failed run, report available here.

@Gchauvon
Copy link
Contributor

Gchauvon commented Nov 5, 2024

Hello @cfuguet, we got some errors with VCS-2023. Do you have an idea ?
It seems that the hpdcache_user_cfg_t HPDcacheUserCfg is not up to date with the definition in hpdcache_pkg.sv

Error-[IAP] Illegal assignment pattern
cva6/core/cache_subsystem/cva6_hpdcache_subsystem.sv, 192
cva6_hpdcache_subsystem, "wbufSendFeedThrough:1'b0"
  Assignment pattern is illegal due to: Named field is not present in the 
  target of Assignment Pattern

Error-[BPRHS] Bad RHS expression of parameter
cva6/core/cache_subsystem/cva6_hpdcache_subsystem.sv, 192
"HPDcacheUserCfg"
  The RHS expression of the parameter could not be evaluated.
  localparam hpdcache_user_cfg_t HPDcacheUserCfg = 
  '{nRequesters:HPDCACHE_NREQUESTERS, paWidth:CVA6Cfg.PLEN, 
  wordWidth:CVA6Cfg.XLEN, sets:CVA6Cfg.DCACHE_NUM_WORDS, 
  ways:CVA6Cfg.DCACHE_SET_ASSOC, clWords:(CVA6Cfg.DCACHE_LINE_WIDTH / 
  CVA6Cfg.XLEN), reqWords:1, reqTransIdWidth:CVA6Cfg.DcacheIdWidth, 
  reqSrcIdWidth:3, victimSel:HPDCACHE_VICTIM_RANDOM, 
  dataWaysPerRamWord:__minu(CVA6Cfg.DCACHE_SET_ASSOC, (128 / CVA6Cfg.XLEN)), 
  dataSetsPerRam:CVA6Cfg.DCACHE_NUM_WORDS, dataRamByteEnable:1'b1, 
  accessWords:__maxu((CVA6Cfg.DCACHE_LINE_WIDTH / (2 * CVA6Cfg.XLEN)), 1), 
  mshrSets:((CVA6Cfg.NrLoadBufEntries < 16) ? 1 : (CVA6Cfg.NrLoadBufEntries / 
  2)), mshrWays:((CVA6Cfg.NrLoadBufEntries < 16) ? CVA6Cfg.NrLoadBufEntries : 
  2), mshrWaysPerRamWord:((CVA6Cfg.NrLoadBufEntries < 16) ? 
  CVA6Cfg.NrLoadBufEntries : 2), mshrSetsPerRam:((CVA6Cfg.NrLoadBufEntries < 
  16) ? 1 : (CVA6Cfg.NrLoadBufEntries / 2)), mshrRamByteEnable:1'b1, 
  mshrUseRegbank:(CVA6Cfg.NrLoadBufEntries < 16), 
  refillCoreRspFeedthrough:1'b1, refillFifoDepth:2, 
  wbufDirEntries:CVA6Cfg.WtDcacheWbufDepth, 
  wbufDataEntries:CVA6Cfg.WtDcacheWbufDepth, wbufWords:1, wbufTimecntWidth:3, 
  wbufSendFeedThrough:1'b0, rtabEntries:4, memAddrWidth:CVA6Cfg.AxiAddrWidth, 
  memIdWidth:CVA6Cfg.MEM_TID_WIDTH, memDataWidth:CVA6Cfg.AxiDataWidth};
  Instance: 
  uvmt_cva6_tb.cva6_dut_wrap.cva6_tb_wrapper_i.i_cva6.gen_cache_hpd.i_cache_subsystem
  Please check for undeclared variables, nets, parameters with unknown values,
  hierachical references or illegal operators.

@cfuguet
Copy link
Contributor

cfuguet commented Nov 5, 2024

Hello @Gchauvon, yes, I did not have the time yet to make the modifications in the CVA6 to support the latest version of the HPDcache. There are some changes in the parameters and the interface.

I will do it today. and make a pull request on the CVA6. I will let you know when it is done.

@JeanRochCoulon
Copy link
Contributor

Superseeded by #2579

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 6, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/submodules/core/cache_subsystem/hpdcache-edd501c branch November 6, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants