Transaction deduplication index should use original expiration time (…

…instead of runtime_expiration) since transaction can be valid longer than 1h
openhive-network · Oct 28, 2024 · 682d7f7 · 682d7f7
1 parent 8d0a838
commit 682d7f7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/libraries/chain/database.cpp b/libraries/chain/database.cpp
@@ -4468,7 +4468,8 @@ void database::_apply_transaction(const std::shared_ptr<full_transaction_type>&
 
     create<transaction_object>([&](transaction_object& transaction) {
       transaction.trx_id = trx_id;
-      transaction.expiration = full_transaction->get_runtime_expiration();
+      /// WARNING: here we have to use original expiration time (instead of runtime_expiration) since transaction is valid up to HIVE_MAX_TIME_UNTIL_SIGNATURE_EXPIRATION
+      transaction.expiration = trx.expiration;
     });
 
     if( _benchmark_dumper.is_enabled() )