Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[items] Fix PersistedItem extending PersistedState type defs #399

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

Dopeyr
Copy link
Contributor

@Dopeyr Dopeyr commented Nov 10, 2024

Fixes #398.
Regression from #396.

@Dopeyr Dopeyr requested a review from a team as a code owner November 10, 2024 10:38
Signed-off-by: Florian Hotze <[email protected]>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Good catch.

FYI I have pushed a minor change to your PR to improve JSDoc.

@florian-h05 florian-h05 added the bug Something isn't working label Nov 10, 2024
@florian-h05 florian-h05 added this to the to be released milestone Nov 10, 2024
@florian-h05 florian-h05 changed the title Restore PersistedItem extending PersistedState in type defs #398 [items] Fix PersistedItem extending PersistedState type defs Nov 10, 2024
@florian-h05 florian-h05 merged commit aaa5a80 into openhab:main Nov 10, 2024
4 checks passed
@florian-h05
Copy link
Contributor

Congratulations to your first contribution to openhab-js 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'state' does not exist on type 'PersistedItem'.ts(2339)
2 participants