-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serial-transport] [WIP] jSerialComm - Initial Contribution #4081
Draft
mvalla
wants to merge
7
commits into
openhab:main
Choose a base branch
from
mvalla:jserialcomm-transport
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvalla
force-pushed
the
jserialcomm-transport
branch
from
February 5, 2024 16:31
443e113
to
7425091
Compare
…n jSerialComm Signed-off-by: MV <[email protected]>
Signed-off-by: MV <[email protected]>
…iptions change Signed-off-by: MV <[email protected]>
Signed-off-by: MV <[email protected]>
… ports, use getSystemPortPath() otherwise. Fixed getCurrentOwner. Signed-off-by: MV <[email protected]>
Signed-off-by: MV <[email protected]>
Signed-off-by: MV <[email protected]>
mvalla
force-pushed
the
jserialcomm-transport
branch
from
April 18, 2024 21:56
7425091
to
3b047c5
Compare
wborn
reviewed
Jul 9, 2024
<parent> | ||
<groupId>org.openhab.core.bundles</groupId> | ||
<artifactId>org.openhab.core.reactor.bundles</artifactId> | ||
<version>4.2.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
<version>4.2.0-SNAPSHOT</version> | |
<version>4.3.0-SNAPSHOT</version> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative Serial Port Provider based on https://github.com/Fazecast/jSerialComm.
From website: jSerialComm is a Java library designed to provide a platform-independent way to access standard serial ports without requiring external libraries, native code, or any other tools. It is meant as an alternative to RxTx and the (deprecated) Java Communications API, with increased ease-of-use, an enhanced support for timeouts, and the ability to open multiple ports simultaneously.
Regarding jSerialComm :
This is a PoC of a new transport based on jSerialComm.
Few features still have to be sorted out as the mapping with OH serial tranport / RxTx is not always straight forward.
Related to #3982