Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch R-tree index triggers #664

Merged
merged 1 commit into from
May 31, 2023
Merged

Patch R-tree index triggers #664

merged 1 commit into from
May 31, 2023

Conversation

jyutzler
Copy link
Contributor

@jyutzler jyutzler commented May 31, 2023

Follow-up of #661

Swallows #663

drop _old_geom_notnull suffix from _update6 trigger and _old_geom_null suffix from _update7 trigger

also: revising summary based on OAB feedback

Follow-up of #661

drop _old_geom_notnull suffix from _update6 trigger
and _old_geom_null suffix from _update7 trigger

also: revising summary based on OAB feedback
@jyutzler jyutzler added the Substantive Change Requires a minor revision label May 31, 2023
@jyutzler jyutzler added this to the 1.4.0 milestone May 31, 2023
@jyutzler jyutzler self-assigned this May 31, 2023
@jyutzler jyutzler merged commit e59d7e5 into master May 31, 2023
@jyutzler jyutzler deleted the 663-rtree-patch branch May 31, 2023 14:40
@@ -60,6 +60,6 @@ See <<Clause_Critical>> for more information on critical changes and
|[yellow-background]#link:https://github.com/opengeospatial/geopackage/pull/661[#661]#
|[yellow-background]#S#
|[yellow-background]#Annex F.3#
|[yellow-background]#Deprecate update1 and update3 triggers, add update5, update6, and update7 triggers#
|[yellow-background]#Replace update1 trigger with update6 and update7 to support upsert operations#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mention of update3 replaced by update5 should likely be kept, shouldn't it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ambivalent here. It is fully explained here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, doesn't matter much to me. Just wanted to check if that was accidentally removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Substantive Change Requires a minor revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants