Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append warning message to GRUB menu "ONIE: Install OS" #1066

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

david56
Copy link
Contributor

@david56 david56 commented Sep 4, 2024

If you go into "ONIE: Install OS" option it will screw up the boot order of the box, and automatically always boot into ONIE instead of the pre-installed NOS. This is a problem and not user friendly, and there should be a warning message in the window, that alerts you that clicking that menu option will reset the boot order. The boot order will not boot into the NOS, until you install a new OS.

If you go into "ONIE: Install OS" option it will screw up the boot order of
the box, and automatically always boot into ONIE instead of the pre-installed
NOS. This is a problem and not user friendly, and there should be a warning
message in the window, that alerts you that clicking that menu option will
reset the boot order. The boot order will not boot into the NOS, until you
install a new OS.

Signed-off-by: david_yang <[email protected]>
@mshych
Copy link
Collaborator

mshych commented Sep 17, 2024

Hi,
It can be not so good to make globally for all systems.

  1. It's possible that some users already have automation and expect specific output.
  2. This warning is not so relevant for systems with UEFI boot, where boot order is defined by efiboot entries.
    You can overwrite grub config for your specific system, e.g. ./machine/manufacturer/system/rootconf/grub/grub-common.cfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants