Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove blending, and just load blend #279

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Conversation

peterdudfield
Copy link
Collaborator

@peterdudfield peterdudfield commented Aug 28, 2023

Pull Request

Description

Remove blend from API for loading 4 hour view.
Need blend service > 0.0.12
This speeds up api for 4 hour view from 7 seconds to 3 seconds (locally)

Helps with #61

How Has This Been Tested?

  • CI tests

  • run it locally

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Aug 28, 2023
@peterdudfield peterdudfield marked this pull request as ready for review August 28, 2023 21:03
Copy link
Collaborator

@rachel-labri-tipton rachel-labri-tipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @peterdudfield, this looks good to me, but I did get this error when I tried to run it locally using docker:
Screenshot 2023-08-30 at 12 31 02
maybe this was fixed with a newer version of the datamodel? I'm using 1.5.11

@peterdudfield
Copy link
Collaborator Author

hey @peterdudfield, this looks good to me, but I did get this error when I tried to run it locally using docker: Screenshot 2023-08-30 at 12 31 02 maybe this was fixed with a newer version of the datamodel? I'm using 1.5.11

yea. good to upgrade to the latest and rebuild docker

@peterdudfield peterdudfield merged commit 12fe31b into main Aug 30, 2023
1 check passed
@peterdudfield peterdudfield deleted the issue/remove-blend-2 branch August 30, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants