Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try and except around file move #292

Merged
merged 1 commit into from
Sep 21, 2024
Merged

try and except around file move #292

merged 1 commit into from
Sep 21, 2024

Conversation

peterdudfield
Copy link
Collaborator

@peterdudfield peterdudfield commented Sep 19, 2024 •
edited
Loading

Pull Request

Description

Add try and except around moving a file.
An error happens if another satellite consumer, has already moved it

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review September 19, 2024 12:27
@peterdudfield peterdudfield merged commit 18cf725 into main Sep 21, 2024
3 of 5 checks passed
@peterdudfield peterdudfield deleted the fix-copy-old-file-bug branch September 21, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADIMANV ADIMANV Awaiting requested review from ADIMANV

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdudfield