Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for 0000-NA filenames #187

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix regex for 0000-NA filenames #187

merged 2 commits into from
Aug 14, 2023

Conversation

jacobbieker
Copy link
Member

@jacobbieker jacobbieker commented Aug 14, 2023

Pull Request

Description

The regex for getting the datetime from the filename breaks when there is a filename like:
MSG4-SEVI-MSG15-0000-NA-20230814075918.739000000Z-NA
where the 0100-NA string in most RSS imagery is replaced by 0000-NA. This fixes that

Fixes #

How Has This Been Tested?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jacobbieker jacobbieker self-assigned this Aug 14, 2023
Copy link
Collaborator

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, if the test pass then merge away - thanks for this

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #187 (05b4ef3) into main (4c4458c) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   62.37%   62.37%           
=======================================
  Files          10       10           
  Lines        1079     1079           
=======================================
  Hits          673      673           
  Misses        406      406           
Files Changed Coverage Δ
satip/__init__.py 100.00% <100.00%> (ø)
satip/eumetsat.py 73.46% <100.00%> (-3.27%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobbieker jacobbieker merged commit 60bcd61 into main Aug 14, 2023
3 checks passed
@jacobbieker jacobbieker deleted the jacob/group-fix branch August 14, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants