Add logging to pupa clean failsafe #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hancush
requested changes
Aug 7, 2023
Comment on lines
+99
to
+101
| f"This command would delete {num_stale_objects} objects: " | ||
| f"\n{stale_objects}" | ||
| "\nIf you're sure, re-run without --noinput to provide confirmation." |
There was a problem hiding this comment.
Rather than forcing confirmation, what about a flag you can pass with noinput to confirm? For example, you can do apt-get install -y to confirm installations noninteractively.
added 2 commits
August 21, 2023 14:17
hancush
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds logging to the
pupa cleanCLI command. When the failsafe is triggered, we'll also output the stale database objects that were found.