-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive map, including OKAPI-based style markers #2185
base: master
Are you sure you want to change the base?
Interactive map, including OKAPI-based style markers #2185
Conversation
…-12. With a dedication for deg-pl
HI @rapotek what's the status of this PR? Is this ready to test? |
It should be, since 19th of August. But I have to recall all details coded here. |
OK, so let me test and review what's going here.. BTW: if something works too slowly here please feel free to scream loudly :) - at least I have less time and energy for OC sometimes but usually if someone request something I try to meet the requests |
…nd GeoCacheLogCommons; controller code further reduced; some templates gathered in one to reduce code redundancy
@rapotek i tried to check how it works in my local env. but I'm not sure how to see such new map. Is it integrated with any existed view? If not can you just fill the example in test controller... |
@kojoty It is written in the OP, but in short:
If you want to see OKAPI-based style markers (more advanced than the simple ones), set a corresponding option on the main neighbourhood configuration page. |
…iew and Api controllers separated
The description below is copied and modified from recently closed PR #2182 :
This is a proposition of changes to an existing Dynamic Map, together with corresponding changes is My Neighbourhood. Because of the nature of changes, as perceived from an external user point, I named it an Interactive Map.
IMPORTANT: Because there is a bunch of changes which I consider should be validated by someone, and not only developers but OC Team and advanced users too, the whole set of changes is made to coexist with an official My Neighbourhood, but replacing it after validation should require few changes only, apart from files relocation. To assure this coexistence, some MyNeighbourhood files have been simply copied to another location, while another ones has been only slightly changed.
What is new from a user point of view:
What is new from a developer point of view (main things):
_DEFAULT_
section.DynamicMap
itself (nowInteractiveMap
), its tools etc. have been rewritten to the more objective version, with prototyping where there is a chance for more than one instance creation.InteractiveMapServices
global object should be now an entry point for every external usage.markerData
.public/images/map_markers/okapi
folder, where in most cases one file maps one cache or log detailed state. The 'new' suffixed icons, defined in OKAPI but not used currently, are created too, to be compliant with full OKAPI style. I suppose, they might be useful in the future.Above changes should be available for validation for OCTeam, Advanced Users and System Admins under '/MyNbhInteractive' relative url.
Should work (tested) on Firefox 78, Chrome 83, Edge 44. A 'Simple' style does not show latest logs on IE 11 because of SVG icons, but current My Neighbourhood does not show them too. An 'Okapi' style should work (tested) on IE 11.