Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path params as types #1982

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

prewk
Copy link
Contributor

@prewk prewk commented Oct 30, 2024

Changes

Make pathParamsAsTypes work with integer/boolean types

Fixes #1930

Also, corepack added a packageManager to package.json which is normally useful, but I can remove it if you want.

Checklist

  • Unit tests updated

@prewk prewk requested a review from a team as a code owner October 30, 2024 21:08
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 0af7920

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@prewk
Copy link
Contributor Author

prewk commented Oct 30, 2024

Oh, I'll remove the packageManager property I guess

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you!

@drwpow
Copy link
Contributor

drwpow commented Nov 8, 2024

Also packageManager is fine to keep or remove. We might be adding it in the future; looking at potentially adding Turbopack

@drwpow drwpow merged commit 8d00218 into openapi-ts:main Nov 8, 2024
8 checks passed
@openapi-ts-bot openapi-ts-bot mentioned this pull request Nov 8, 2024
DjordyKoert pushed a commit to DjordyKoert/openapi-typescript that referenced this pull request Nov 28, 2024
* fix(openapi-typescript): Make pathParamsAsTypes work with integer/boolean types

* Update changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generates incorrect dynamic path with integer parameters
2 participants