Fix empty request / response bodies

[pvanagtmaal]

Changes

Fixes #1109 and #1174

How to Review

Nothing special

Checklist

• Unit tests updated
• docs/ updated (if necessary)
• pnpm run update:examples run (only applicable for openapi-typescript)

[changeset-bot]

🦋 Changeset detected

Latest commit: 32ac1e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
openapi-typescript	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pvanagtmaal]

@drwpow The tests that are failing are because we cannot simply return never for responses anymore because the headers could still be set. Do you consider this a problem / breaking change? IMO it is not a problem, since types of response objects that were never wouldn't be used anyways. 🤔

[drwpow]

This is a good change to make! No I think you’re right—I can’t see this actually being a “breaking” change for most people; this feels like a bugfix. content: never; is a better type than having its parent be never.

I’m OK with updating the test snapshots to reflect the changes made here. There’s not really an automated script to handle it because I kinda like making updating snapshots annoying :P (i.e. it shouldn’t happen frequently and in bulk)

[drwpow]

Also, so sorry to do this to you, but I realized Prettier was out of date and bumped it 😓. The diff shouldn’t be too bad, but let me know if you encounter any annoying conflicts.

[pvanagtmaal]

Not sure why the CI is failing, tests are passing locally:

~/openapi-typescript/packages/openapi-typescript on  fix/empy-response-or-request-objects [$?] is 📦 v6.4.3 via  v18.10.0
❯ pnpm run test

> [email protected] test ~/openapi-typescript/packages/openapi-typescript
> run-p -s test:*


 RUN  v0.33.0 ~/openapi-typescript/packages/openapi-typescript

 ✓ test/cli.test.ts (8) 22314ms
 ✓ test/cjs.test.ts (1) 709ms
 ✓ test/yaml.test.ts (1) 430ms
 ✓ test/utils.test.ts (35)
 ✓ test/schema-object.test.ts (67)
 ✓ test/load.test.ts (7)
 ✓ test/response-object.test.ts (2)
 ✓ test/operation-object.test.ts (1)
 ✓ test/index.test.ts (26) 22131ms
 ✓ test/paths-object.test.ts (3)
 ✓ test/components-object.test.ts (5)
 ✓ test/request-body-object.test.ts (2)
 ✓ test/invalid.test.ts (2)
 ✓ test/path-item-object.test.ts (3)
 ✓ test/webhooks-object.test.ts (2)
 ✓ test/header-object.test.ts (1)

 Test Files  16 passed (16)
      Tests  166 passed (166)
   Start at  10:02:05
   Duration  22.87s (transform 465ms, setup 0ms, collect 2.46s, tests 45.70s, environment 3ms, prepare 1.76s)

[drwpow]

@pvanagtmaal you’ll need to update the snapshots in examples/* with the newly-generated types. The tests are failing on my machine. Also be sure to run pnpm run build so you’re testing the freshly-built client (many tests test the actual compiled CLI version just to make sure it’s working, and that won’t rebuild automatically just from editing .ts files unless you’re running pnpm run dev)!

[drwpow]

🎉 🎉 🎉

These were the type of test failures we like to see 😄

[drwpow]

Thank you! This is a huge fix 🙏