fix(dm): remove 59-persistent-storage-dm.rules (bsc#1232063) (SLE15-SP6:Update) #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59-persistent-storage-dm.rules has been obsolete for a long time. The blkid builtin is run from 13-dm.rules. The "dmsetup info" call in this file is actually harmful, because it overrides properties that have already been set in 10-dm.rules, in particular DM_SUSPENDED, to which it assigns a string like "Active" or "Suspended", whereas the stock DM rules and systemd rules expect the property to have the value "0", or "1", respectively. Signed-off-by: Martin Wilck <[email protected]> (cherry picked from commit dracut-ng/dracut-ng@d2ade8a)
aafeijoo-suse
changed the title
aafeijoo-suse
merged commit 98d7f03
into
openSUSE:SLE-15-SP6_Update
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
59-persistent-storage-dm.rules has been obsolete for a long time. The blkid builtin is run from 13-dm.rules. The "dmsetup info" call in this file is actually harmful, because it overrides properties that have already been set in 10-dm.rules, in particular DM_SUSPENDED, to which it assigns a string like "Active" or "Suspended", whereas the stock DM rules and systemd rules expect the property to have the value "0", or "1", respectively.
Signed-off-by: Martin Wilck [email protected]
(cherry picked from commit dracut-ng/dracut-ng@d2ade8a)