fix(nvmf): require NVMeoF modules (bsc#1230468) #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating initramfs for universal boot image such as an installer, we can't include any machine-specific IDs. Let's move the check for /etc/nvme/hostnqn and /etc/nvme/hostid files presence to the hostonly section to avoid unsatisfied requirements. Signed-off-by: Tomas Bzatek <[email protected]> (cherry picked from commit dracut-ng/dracut-ng@54cd647)
Signed-off-by: Martin Wilck <[email protected]> (cherry picked from commit dracut-ng/dracut-ng@4133270) bsc#1230468
nvme_rdma was not installed, even if it was required, whereas nvme_tcp was installed in non-TCP setups. nvme_fabrics will be pulled in automatically by any transport module and doesn't need to be installed explicitly. Fix it. (cherry picked from commit dracut-ng/dracut-ng@3748ed4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some minimal OS images, adding the
nvmfdracut module to the initrd does not fail, although the required nvme kernel modules are not shipped with the image. That implies that users didn't see any errors when building the initrd, so they expect booting from NVMe-oF to work, but it obviously fails.Fixes added: