Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dracut.spec): do not check if fillup template exists at %post end (SLE15-SP6:GA) #325

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(dracut.spec): do not check if fillup template exists at %post end (SLE15-SP6:GA) #325

merged 1 commit into from
Apr 30, 2024

Conversation

aafeijoo-suse
Copy link
Collaborator

@aafeijoo-suse aafeijoo-suse commented Apr 30, 2024 •
edited
Loading

If the test returns false, the %post script also exits with error and the rpm build fails.

Issue detected on the IBS after the build of ae26ad5 failed.

Fixes ae26ad5

tblume
tblume reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@tblume tblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's a bit strange.
IMHO, the package installation requires the system to be rw, otherwise the new files can't be installed.
So it should not happen that the system is ro in post-install.

@aafeijoo-suse
fix(dracut.spec): do not check if fillup template exists at %post end
d3566a2 
If the test returns false, the %post script also exits with error and the rpm
build fails.

Fixes ae26ad5
@aafeijoo-suse
Copy link
Collaborator Author

Adding the explanation here for future readers. If the last command from %post returns non-zero (in this case, [ -f /var/adm/fillup-templates/sysconfig.kernel-mkinitrd ] if the file does not exist), %post exits with a non-zero value and the rpm build fails.

@aafeijoo-suse aafeijoo-suse changed the title fix(dracut.spec): handle error in %post (SLE15-SP6:GA) fix(dracut.spec): do not check if fillup template exists at %post end (SLE15-SP6:GA) Apr 30, 2024
tblume
tblume approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@tblume tblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aafeijoo-suse aafeijoo-suse merged commit 3edf43b into openSUSE:SLE-15-SP6_GA Apr 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tblume tblume tblume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aafeijoo-suse @tblume